ci: Build without testing in the min-compiler jobs - #1679
Merged
Conversation
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1679 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 176 176
Lines 15995 15995
Branches 3666 3666
=======================================
Hits 15654 15654
Misses 255 255
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
ci/tools-only-build
branch
from
August 28, 2026 13:43
bbe0972 to
f368bb7
Compare
EVMONE_TESTING defaults to OFF and is the only configuration where GTest is never fetched, but every job passed it ON, so nothing noticed if the code built under EVMONE_TOOLS grew a dependency on GTest. That matters now that evmone::testutils carries the fixture runners. gcc-min and clang-min build the default configuration first, run the tool once to check it works at all, then reconfigure with testing on. The second pass reuses every object of the first, so this costs a configure, not a build.
chfast
force-pushed
the
ci/tools-only-build
branch
from
August 28, 2026 16:37
f368bb7 to
ea72099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EVMONE_TESTINGdefaults toOFF, and that is the only configuration where GTest is neverfetched — but every job funnels through a
buildcommand that passes-DEVMONE_TESTING=ON, sothe default has never been built in CI. Nothing would notice if the code built under
EVMONE_TOOLSgrew a dependency on GTest, which matters now thatevmone::testutilscarries thefixture runners and #1676 relies on them staying GTest-free.
gcc-minandclang-minnow configure the default first, build it, runevmone runonce tocheck the tool works at all, and then reconfigure with testing on in the same directory. Measured
locally: the first pass compiles 54 objects, the second 111, and none of the 54 is recompiled —
165 distinct in total, the same as a single testing-on build. So this costs an extra CMake
configure and a smoke test, not a second build.